Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure sync URL is set to sane value if .env is not configured. #27054

Merged
merged 2 commits into from
Dec 18, 2024

Conversation

goodov
Copy link
Member

@goodov goodov commented Dec 18, 2024

Browser DCHECKs if sync server is not configured in .env.

Resolves brave/brave-browser#42945

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@goodov goodov added CI/skip-android Do not run CI builds for Android CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS CI/skip-windows-x64 Do not run CI builds for Windows x64 CI/skip-macos-arm64 Do not run CI builds for macOS arm64 labels Dec 18, 2024
@goodov goodov marked this pull request as ready for review December 18, 2024 08:28
@goodov goodov requested a review from a team as a code owner December 18, 2024 08:28
@@ -15,6 +15,8 @@ declare_args() {

if (is_official_build) {
assert(brave_sync_endpoint != "")
} else if (brave_sync_endpoint == "") {
brave_sync_endpoint = "https://sync-v2.bravesoftware.com/v2"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's change url to https://sync-v2.brave.software/v2, which is a dev server.

@goodov goodov enabled auto-merge (squash) December 18, 2024 10:08
@goodov goodov merged commit 9757d93 into master Dec 18, 2024
20 checks passed
@goodov goodov deleted the default-to-staging-sync-url branch December 18, 2024 10:43
@github-actions github-actions bot added this to the 1.75.x - Nightly milestone Dec 18, 2024
@brave-builds
Copy link
Collaborator

Released in v1.75.108

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-macos-arm64 Do not run CI builds for macOS arm64 CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default sync server URL to staging URL if not set in .env
3 participants